24 lines
1.0 KiB
Markdown
24 lines
1.0 KiB
Markdown
## External review summary
|
|
|
|
Status: approved
|
|
|
|
Reviewer inspected the ticket, investigation artifact, and implementation commit `501dcc9 fix: show initial TUI user message` in branch `tui-new-session-first-message-missing`.
|
|
|
|
Findings:
|
|
|
|
- The implementation matches the ticket intent and investigation result.
|
|
- The controller-side pre-run optimistic `Event::UserMessage` broadcast is removed from the authoritative path.
|
|
- Live `Event::UserMessage` emission is tied to persisted `LogEntry::UserInput` / session-log-derived ordering.
|
|
- Fresh sessions should now see initial `SegmentRotated` before the committed user message event, preserving the first message in the TUI view.
|
|
- The fix does not use a TUI-only fake/pending message.
|
|
- No unnecessary protocol/schema expansion was found.
|
|
- Existing snapshot restore, later sends, queued input, and composer input history did not show obvious regressions from the diff.
|
|
|
|
Validation reviewed:
|
|
|
|
- `cargo fmt`
|
|
- `cargo test -p pod`
|
|
- `cargo test -p tui`
|
|
|
|
Parent decision needed: none.
|