Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity
b6029220ff
yoi/.yoi/tickets/00001KWPC13WQ/thread.md

20 KiB
Raw Blame History

作成

LocalTicketBackend によって作成されました。

Intake summary

Marked ready by yoi ticket state.

State changed

Marked ready by yoi ticket state.

State changed

Ticket を workspace-panel が queued にしました。

Decision

Routing decision: implementation_ready

Reason:

  • Ticket は Workspace Backend の Repository registry を config-driven にする範囲、非目標、受け入れ条件が具体化されている。
  • WorkspaceBackendConfigFile / .yoi/workspace-backend.local.toml に [[repositories]] を追加し、Browser/API が configured repositories のみを返すという binding decision が明確。
  • RepositoryId / RepositorySelector / RepositoryPoint の用語境界と、secret/path leak を避ける Browser-facing invariant が明記されている。
  • typed relation blocker は 0 件、OrchestrationPlan record は 0 件。
  • queued notification は human authorized routing であり、今回の routing acceptance 後にのみ implementation side effect へ進める。

Evidence checked:

  • Ticket body / thread / artifacts。
  • TicketRelationQuery(00001KWPC13WQ): 0 件。
  • TicketOrchestrationPlanQuery(00001KWPC13WQ): 0 件。
  • Orchestrator worktree git status: clean on orchestration。
  • queued Ticket 一覧: この Ticket 1件のみ。ready / inprogress は 0 件。
  • visible Pods: 2 visible pods（既存 visible state の確認のみ、spawn は未実施）。
  • TicketDoctor: 0 errors / 既存 diagnostics のみ。
  • Bounded code map: crates/workspace-server/src/config.rs, crates/workspace-server/src/repositories.rs, crates/workspace-server/src/server.rs, crates/workspace-server/src/store.rs, repository-related web workspace files。

IntentPacket:

Intent:

  • Workspace Backend の Repository view を workspace root/cwd の暗黙 fallback から、.yoi/workspace-backend.local.toml の explicit Repository registry に移行する。
  • /api/repositories と /api/repositories/{id}/log は configured repositories のみを扱い、未設定時は empty list + typed warning diagnostic を返す。

Binding decisions / invariants:

  • --workspace は Repository root ではなく workspace config root / local descriptor root として扱う。
  • uri = "." は backend process cwd ではなく workspace config root 相対として解釈する。
  • cwd / workspace root を暗黙 Repository として Browser/API に返す fallback は廃止する。
  • dogfood workspace config には id = "main", provider = "git", uri = "." 相当の explicit Repository entry を追加する。
  • v0 provider は git 主対象。local_fs は必要なら placeholder/diagnostic 程度。
  • RepositorySelector は provider-specific な未解決 locator、RepositoryPoint は解決済み evidence として、Git branch/tag/hash 固定抽象にしない。
  • Browser-facing response は token/auth ref/secret、不要な absolute host path、internal config/store/runtime paths を漏らさない。

Requirements / acceptance criteria:

  • .yoi/workspace-backend.local.toml に [[repositories]] を書ける。
  • /api/repositories は configured repositories のみを返す。
  • Repository 未設定 workspace は empty list + repository_config_empty 相当 warning diagnostic。
  • configured Git Repository では branch/head/status/log など既存 UI が必要とする summary を取得できる。
  • /api/repositories/{id}/log は configured Git Repository id のみ受け付け、未知 id / unsupported provider は typed sanitized error。
  • 既存 web UI は未設定時にも壊れず、明示 Repository がある場合だけ repository view を表示できる。

Implementation latitude:

  • 型名、module分割、API response shape の細部は既存 workspace-server / web workspace style に合わせてよい。
  • config TOML の comments/format preservation は既存 local config serializer の範囲で扱う。
  • Browser-facing path 表示は safe display name / sanitized summary に寄せ、必要なら absolute path を API 内部で使っても response に不要露出しない。
  • focused tests の構成は backend helper/route-level と web model/component-levelの現実的な範囲で選んでよい。

Escalate if:

  • credential/clone/fetch/write operation、Runtime materialization、Execution Workspace 作成、multi-workspace store 移行、Ticket target からの RepositoryPoint 解決が必要になる場合。
  • Browser-facing API に secret/auth ref/internal absolute paths を出さないと実装できない場合。
  • RepositorySelector / RepositoryPoint の概念境界を設計変更する必要が出た場合。

Validation:

  • cargo test -p yoi-workspace-server
  • cargo check -p yoi
  • cd web/workspace && deno task check && deno task test
  • git diff --check
  • yoi ticket doctor
  • nix build .#yoi --no-link は Cargo.lock / dependency / resource packaging / Nix 変更がある場合だけ実行し、未実行なら理由を報告する。

Current code map:

  • Config: crates/workspace-server/src/config.rs (WorkspaceBackendConfigFile, local config load/write/resolve)。
  • Repository projection: crates/workspace-server/src/repositories.rs (LocalRepositoryReader, RepositorySummary, git inspect/log)。
  • API wiring: crates/workspace-server/src/server.rs (/api/repositories, /api/repositories/{repository_id}, log route)。
  • Store/schema context: crates/workspace-server/src/store.rs repositories table migration context。
  • Web: workspace repository panels/routes using /api/repositories and repository log summaries.

Critical risks / reviewer focus:

  • No implicit workspace-root/cwd repository fallback remains in Browser/API output.
  • configured repository ids, unknown ids, and unsupported providers fail closed with typed sanitized diagnostics.
  • path/secret/internal config/store/runtime details do not leak to Browser-facing responses.
  • uri = "." is resolved against workspace config root, not process cwd.
  • dogfood .yoi/workspace-backend.local.toml contains explicit main repository entry without introducing secret/local-only fields into tracked records.

State changed

Queued acceptance recorded after Workspace Dashboard Queue notification authorized Orchestrator routing.

Checked context:

  • Ticket body / thread / artifacts。
  • TicketRelationQuery(00001KWPC13WQ): blocking relation 0 件。
  • TicketOrchestrationPlanQuery(00001KWPC13WQ): prior record 0 件。今回 accepted_plan を記録済み。
  • Orchestrator worktree git status: clean on orchestration。
  • queued Ticket はこの Ticket 1件のみ。ready / inprogress は 0 件。
  • visible Pods / TicketDoctor / bounded code map を確認。

Acceptance basis:

  • concrete missing decision / information は残っていない。
  • Ticket の scope は explicit Repository registry / API projection / web compatibility に閉じており、非目標も明確。
  • side effect はこの queued -> inprogress acceptance 後に、worktree-workflow に沿って implementation worktree を作成してから開始する。

Implementation report

Implementation routing update:

  • Worktree-workflow に従い implementation worktree を作成した。
    • Worktree: /home/hare/Projects/yoi/.worktree/00001KWPC13WQ-repository-registry
    • Branch: work/00001KWPC13WQ-repository-registry
  • Worktree には tracked .yoi project records が見えている。
  • .yoi/memory / .yoi/runtime / .yoi/log / .yoi/logs / .yoi/local / .yoi/*.lock / .yoi/*secret* は作成直後に存在しないことを確認した。
  • Sibling Coder Pod yoi-coder-00001KWPC13WQ-repository-registry を起動した。
  • Scope policy: runtime workspace root は read-only、implementation worktree は write 可。Coder task では root/original workspace での read/write/validation/git operation を禁止し、この implementation worktree だけを作業対象に指定した。
  • 完了後は diff / validation evidence を Orchestrator が確認し、別 sibling Reviewer Pod に read-only review を依頼する。StopPod は既知の不具合があるため使用しない。

Implementation report

Implementation progress report:

  • Coder Pod completed implementation and committed 2f0d1cee feat: add workspace repository registry on branch work/00001KWPC13WQ-repository-registry.
  • Worktree status was clean after commit.
  • Changed files include:
    • .yoi/workspace-backend.local.toml
    • resources/workspace-backend.default.toml
    • crates/workspace-server/src/config.rs
    • crates/workspace-server/src/lib.rs
    • crates/workspace-server/src/repositories.rs
    • crates/workspace-server/src/server.rs
    • web workspace repository/sidebar route files.
  • Implementation summary: explicit [[repositories]] registry, config-root-relative uri, no implicit cwd/workspace-root repository fallback, empty registry diagnostic, configured-id-only log route, typed sanitized unknown/unsupported diagnostics, dogfood main repository entry.
  • Orchestrator reran validation in the implementation worktree:
    • git diff --check: pass
    • cargo test -p yoi-workspace-server: pass（63 lib tests + 2 main tests）
    • cargo check -p yoi: pass
    • cd web/workspace && deno task check: pass（0 errors / 0 warnings）
    • cd web/workspace && deno task test: pass（13 tests）
    • yoi ticket doctor: ok
  • nix build .#yoi --no-link は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。
  • External review will be requested via a read-only sibling Reviewer Pod. StopPod は使わない。

Review: request changes

External review result: request_changes

Blockers:

  1. Web UI still exposes an implicit hardcoded main repository instead of deriving repository navigation from configured repositories.

    • web/workspace/src/lib/workspace-sidebar/RepositoriesNavSection.svelte:12-25 always renders count 1 and a /repositories/main link labeled “configured repository”。
    • WorkspacePage.svelte:25-29 still defaults repositoryId = 'main', and WorkspacePage.svelte:181-187 loads repository data/tickets even outside the repository route。
    • This violates the acceptance criterion that the web UI behave safely with no configured repositories and display repository views only for explicit repositories. In an empty registry workspace, the sidebar still advertises main。

  2. Browser-facing repository summaries can leak local absolute host paths through Git remotes.

    • crates/workspace-server/src/repositories.rs:223-225 reads git remote -v。
    • parse_remotes exposes fetch_url in GitRemoteSummary (repositories.rs:42-46, 274-291)。
    • sanitize_remote_url only redacts scheme://credentials@host userinfo (repositories.rs:338-345); local absolute remotes such as /home/.../repo.git or file:///home/... are returned unchanged。
    • This conflicts with the Ticket invariant that browser-facing responses must not leak unnecessary absolute host paths/internal path details。

Validation / evidence reviewed:

  • Ticket item.md, routing decision / IntentPacket, and orchestration plan。
  • Commit 2f0d1cee diff/stat/name list and relevant backend/web files。
  • git diff --check 2f0d1cee^ 2f0d1cee had no whitespace errors。
  • Positive backend pieces exist: explicit dogfood main config, config-level [[repositories]], uri = "." workspace-root resolution test, empty-registry repository_config_empty diagnostic, and unknown/unsupported repository log route tests。

Non-blocking follow-ups:

  • Add web-side tests or component-model coverage for empty repository registry / non-main configured repository navigation so the hardcoded fallback cannot regress。
  • Consider a stricter public GitRemoteSummary shape that reports only sanitized display metadata, not raw fetch URLs。

Implementation report

Review-fix implementation report:

  • Coder Pod completed requested changes and committed follow-up 14e63ca5 fix: derive repository UI from registry on branch work/00001KWPC13WQ-repository-registry.
  • Worktree status was clean after commit.
  • Fix summary:
    • Web UI no longer hardcodes implicit main repository navigation/default route behavior.
    • Repository navigation is derived from configured repositories; empty registry does not invent main and can surface diagnostics such as repository_config_empty.
    • Repository details/tickets load only for explicit repository routes.
    • Browser-facing Git remote display values now redact local absolute remotes such as /home/..., /Users/..., Windows-style absolute paths, file:///..., and file://localhost/..., while preserving credential redaction.
    • Added focused web tests for empty registry and non-main configured repository navigation.
  • Orchestrator reran validation in the implementation worktree:
    • git diff --check: pass
    • cargo test -p yoi-workspace-server: pass（63 lib tests + 2 main tests）
    • cargo check -p yoi: pass
    • cd web/workspace && deno task check: pass（0 errors / 0 warnings）
    • cd web/workspace && deno task test: pass（15 tests）
    • yoi ticket doctor: ok
  • nix build .#yoi --no-link は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。
  • Requesting follow-up external review against 2f0d1cee..14e63ca5 and full combined implementation。

Review: approve

External follow-up review result: approve

Blockers: none.

Evidence reviewed in implementation worktree only:

  • Ticket 00001KWPC13WQ item/thread and IntentPacket: explicit config-driven registry, no cwd/workspace-root fallback, uri = "." relative to workspace config root, browser-facing path/secret invariant.
  • git show --stat --check 14e63ca5, git diff --stat 2f0d1cee..14e63ca5, combined changed-file set, and relevant full files.

Findings:

  • Prior blocker 1 fixed: /api/repositories is built from config.repositories only, empty registry returns empty items plus repository_config_empty, sidebar derives links via projectRepositoryNav, no hardcoded /repositories/main remains, WorkspacePage no longer defaults to main, repository fetches happen only for explicit route ids, and non-main ids are covered by tests。
  • Prior blocker 2 fixed: Browser-facing RepositorySummary does not serialize configured uri or resolved local path; Git command failure diagnostics are generic; remote URLs redact credentials and local absolute/file remotes including /home/..., /Users/..., Windows absolute paths, file:///..., and file://localhost/..., with tests。
  • uri = "." resolves against workspace/config root, not process cwd, with unit test。
  • Unknown repository ids map to typed repository_not_configured diagnostics and 404。
  • Unsupported providers for git log map to typed repository_provider_unsupported diagnostics and 400。
  • Dogfood .yoi/workspace-backend.local.toml contains explicit main git repository entry with uri = "." and no secret/local-only fields。
  • No implicit workspace-root/cwd repository fallback found in Browser/API output paths。

Validation note:

  • Reviewer did not rerun the full test suite; reviewer relied on Orchestrator-reported passing validation and performed read-only diff/file inspection。
  • git show --check had no whitespace errors for the fix commit。

No merge-blocking issues found.

State changed

Merge/validation acceptance:

  • Follow-up external review approved the implementation after blocker fixes。
  • Implementation branch work/00001KWPC13WQ-repository-registry was merged into the orchestration branch with merge commit a786fd85 merge: repository registry implementation。
  • Final validation in Orchestrator worktree passed:
    • git diff --check: pass
    • cargo test -p yoi-workspace-server: pass（63 lib tests + 2 main tests）
    • cargo check -p yoi: pass
    • cd web/workspace && deno task check: pass（0 errors / 0 warnings）
    • cd web/workspace && deno task test: pass（15 tests）
    • yoi ticket doctor: ok
  • nix build .#yoi --no-link は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。

Implementation commits:

  • 2f0d1cee feat: add workspace repository registry
  • 14e63ca5 fix: derive repository UI from registry

No merge-blocking issues remain.

State changed

Ticket を closed にしました。

完了

完了。

実装内容:

  • Workspace Backend に explicit [[repositories]] registry を追加した。
  • .yoi/workspace-backend.local.toml / resources/workspace-backend.default.toml に Repository config schema を導入し、dogfood workspace config に explicit main Git repository entry (uri = ".") を追加した。
  • uri = "." は workspace config root 相対として解釈し、process cwd / workspace root を暗黙 Repository として扱う fallback を廃止した。
  • /api/repositories は configured repositories のみを返し、未設定時は empty list + repository_config_empty warning diagnostic を返す。
  • /api/repositories/{id}/log は configured Git repository id のみを受け付け、未知 id / unsupported provider は typed sanitized diagnostics で fail closed するようにした。
  • Browser-facing repository summary は configured uri / resolved local path / secret / internal path を露出せず、Git remote も credentials / local absolute path / file://... を redaction するようにした。
  • Web UI は configured repositories から navigation を導出し、empty registry で hardcoded main repository を invent しないようにした。
  • Focused backend/web tests を追加した。

主な commit / merge:

  • implementation: 2f0d1cee feat: add workspace repository registry
  • review fix: 14e63ca5 fix: derive repository UI from registry
  • merge into orchestration: a786fd85 merge: repository registry implementation

Review:

  • 初回 external review は request_changes。
  • follow-up external review は approve。merge-blocking issue なし。

Final validation in Orchestrator worktree:

  • git diff --check: pass
  • cargo test -p yoi-workspace-server: pass（63 lib tests + 2 main tests）
  • cargo check -p yoi: pass
  • cd web/workspace && deno task check: pass（0 errors / 0 warnings）
  • cd web/workspace && deno task test: pass（15 tests）
  • yoi ticket doctor: ok

未実行:

  • nix build .#yoi --no-link は Cargo.lock / dependency / resource packaging / Nix 変更ではないため未実行。