29 lines
1.1 KiB
Markdown
29 lines
1.1 KiB
Markdown
## External review summary
|
|
|
|
Status: approved
|
|
|
|
Reviewer inspected the ticket and implementation commit `5886f6a fix: align keys UI with TUI viewport` in branch `tui-keys-inline-viewport-ui`.
|
|
|
|
Findings:
|
|
|
|
- The implementation aligns `insomnia keys` with the existing inline viewport convention by using `Viewport::Inline(...)`.
|
|
- Styling and layout are closer to the existing TUI viewport/list conventions.
|
|
- Key management semantics remain unchanged for `SecretStore::set`, `SecretStore::delete`, and `list_ids`.
|
|
- Stored secret values are not displayed.
|
|
- Value entry is rendered with bullets.
|
|
- `KeysApp` / `Action::Set` debug output redacts the secret value.
|
|
- Focused tests cover that raw editing values are not rendered.
|
|
|
|
Non-blocking follow-ups:
|
|
|
|
- Shared inline viewport helpers/style constants may be worth extracting if more similar screens appear.
|
|
- Display-width-aware cursor positioning can be considered later if Unicode-width behavior becomes important.
|
|
|
|
Validation reviewed:
|
|
|
|
- `cargo fmt --check`
|
|
- `cargo test -p tui keys::tests`
|
|
- `cargo check -p insomnia`
|
|
|
|
Parent decision needed: none.
|