yoi/.yoi/tickets/00001KSKBP9YG/artifacts/review-2026-06-13-e2e-harness-rereview.md

Approve.

Delta reviewed:

• Re-reviewed the fix commit b30b43b9 test: cfg-gate e2e observer payloads after the earlier request-changes review.
• Inspected the updated observer module boundary and call sites in crates/tui/src/lib.rs and crates/tui/src/multi_pod.rs, plus the unchanged harness/tests in tests/e2e.

Evidence:

• e2e_observer is now only compiled from crates/tui/src/lib.rs under #[cfg(feature = "e2e-test")]; the previous normal-build no-op facade was removed.
• Observer payload construction is gated at call sites with #[cfg(feature = "e2e-test")], including panel_ready, selection_changed, action_requested, quit_requested, and emit_rows_rendered calls.
• Panel E2E DTOs/helpers (PanelE2eRowKey, PanelE2eRect, PanelE2eRenderedRow, PanelE2eRowsRendered, App::emit_rows_rendered) are now behind #[cfg(feature = "e2e-test")], so the normal panel render path no longer builds row snapshots or retains that runtime helper path.
• The background-task hold seam is still feature-gated: check_background_task_hold and release_background_task_hold calls are under #[cfg(feature = "e2e-test")], and YOI_TUI_TEST_HOLD_BACKGROUND_TASK behavior lives in the gated observer module.
• Mouse capture tracking remains intact in the harness: it tracks ?1000h and ?1006h, click(...) requires both capture modes before injecting PTY bytes, the test waits for rendered rows, asserts selection_changed, and asserts no action_requested dispatch.
• Quit-latency coverage remains intact: the test waits for panel_ready, then verifies an actual pending reload background-task barrier before sending Ctrl+C through the PTY and asserting bounded exit.
• The production/non-production boundary now satisfies the Ticket intent: the harness remains opt-in, observability is read-only and feature-gated, and no UI input/action path is bypassed.

Validation run in /home/hare/Projects/yoi/.worktree/e2e-harness:

• git diff --check 134e8b8b..HEAD — passed.
• cargo fmt --check — passed.
• cargo check -p tui --all-targets — passed.
• cargo check -p yoi --all-targets — passed.
• cargo check -p tui --all-targets --features e2e-test — passed.
• cargo check -p yoi --all-targets --features e2e-test — passed.
• cargo build -p yoi --features e2e-test — passed.
• YOI_E2E_BIN=/home/hare/Projects/yoi/.worktree/e2e-harness/target/debug/yoi cargo test -p yoi-e2e --features e2e --test panel -- --nocapture — passed; 2 tests passed.
• cargo check -p yoi-e2e --all-targets --features e2e — passed.

No source changes were made during re-review.