10 KiB
作成
LocalTicketBackend によって作成されました。
項目更新
Ticket item updated: title, body.
項目更新
Ticket item updated: title, body.
Plan
Implementation started.
Plan for this pass:
- Inspect local Worker protocol transport and current Backend/frontend HTTP operation mappings.
- Add a Backend/runtime protocol command transport that accepts existing
protocol::Methodpayloads rather than per-operation HTTP endpoints. - Route TUI Backend Runtime client through that protocol transport for run/notify/completion/cancel/pause/resume/compact/rewind operations.
- Route browser Console operations through the same protocol transport and stop using HTTP operation endpoints as the normal path.
- Keep existing HTTP endpoints only as compatibility where needed, not as frontend/TUI authority.
Implementation report
Implementation update:
Implemented the first full protocol-transport pass for Backend/runtime Worker controls.
Backend/runtime:
- Added
Runtime::send_protocol_method(...)inworker-runtime.Method::ListCompletionsreturns directEvent::Completionsfor same-command-connection semantics.- Other methods are delivered unchanged to the execution backend.
- Added
WorkerExecutionBackend::dispatch_method(...)and concrete support inWorkerRuntimeExecutionBackend.- This accepts existing
protocol::Methodvalues instead of translating through operation-specific HTTP request DTOs.
- This accepts existing
- Added runtime command WebSocket:
/v1/workers/{worker_id}/protocol/ws- accepts raw
protocol::MethodJSON frames - returns raw direct
protocol::EventJSON frames where needed
- Added workspace-server command WebSocket:
/api/runtimes/{runtime_id}/workers/{worker_id}/protocol/ws/api/w/{workspace_id}/runtimes/{runtime_id}/workers/{worker_id}/protocol/ws
- Added
RuntimeRegistry::send_protocol_method(...)and embedded runtime forwarding.
TUI client:
- Reworked
BackendRuntimeClientsosend(&Method)no longer maps to HTTP/input, lifecycle, or unsupported diagnostics. - It now opens a command WS to
/protocol/wsand sends cloned rawprotocol::Methodvalues. - Direct command response events are merged into the existing event queue alongside observation WS events.
- This removes the previous unsupported handling for pause/resume/compact/completions/rewind at the TUI client transport layer.
Browser Console:
- Added command WS connection to
/protocol/wswhile keeping/events/wsas observation stream. - Removed normal operation use of HTTP
POST /inputandPOST /completionsfrom the Console page. - Composer send now maps to protocol methods:
- user input ->
Method::Runwith protocolSegment[] - system input ->
Method::Notify { auto_run: true } :compact->Method::Compact:rewind->Method::ListRewindTargets:peer->Method::RegisterPeer
- user input ->
- Completion lookup now sends
Method::ListCompletionsover command WS and waits for directEvent::Completions. - Added frontend controls for cancel / pause / resume / compact / rewind target request / rewind to target.
Compatibility note:
- Existing HTTP operation endpoints remain in backend/server as compatibility for now, but the TUI Backend client and browser Console normal path now use protocol transport.
Verification run under nix develop:
cargo fmt -- --checkcargo check -p worker-runtime -p yoi-workspace-server -p client -p tuicargo test -p client backend_runtime --libcargo test -p yoi-workspace-server registry_worker_list_can_be_scoped_by_runtime_id --libcargo test -p worker-runtime --features ws-server --lib worker_backendgit diff --check
Frontend check note:
web/workspace/package.jsoncurrently has no check script and local frontend dependencies are not installed in this worktree.- Attempted temporary
npm exec --package svelte-check --package typescript -- svelte-check, but the tool bootstrap failed before checking project code. - The Svelte page was updated against the generated protocol types in
web/workspace/src/lib/generated/protocol.ts, but a frontend-native check still needs to be run in an environment with the frontend deps installed.
Implementation report
Follow-up implementation after design clarification:
Changed the transport split so /events/ws no longer exists. /protocol/ws is now the single Worker protocol WebSocket for both directions:
- client -> runtime/backend: raw
protocol::MethodJSON frames - runtime/backend -> client: raw
protocol::EventJSON frames
Runtime changes:
- Removed
/v1/workers/{worker_id}/events/wsroute. - Removed runtime-specific event WS envelope/diagnostic frame types.
- Extended
/v1/workers/{worker_id}/protocol/wsto stream snapshot/backlog/live observation events as rawprotocol::Eventwhile also accepting method frames on the same socket.
Workspace Backend changes:
- Removed public
/api/.../events/wsand/api/w/.../events/wsroutes. - Removed Backend client event WS envelope types.
- Workspace
/protocol/wsnow proxies/streams raw protocol events and forwards raw protocol methods on the same socket. - Runtime observation source endpoint generation now targets runtime
/protocol/wsinstead of/events/ws.
Client/frontend changes:
- TUI
BackendRuntimeClientno longer opens a separate observation socket. It uses only/protocol/wsfor send and receive. - Browser Console no longer opens both observation and command sockets. It uses one protocol socket for replay/live events, completions, rewind targets, and controls.
- Removed old frontend
ClientWorkerEventWs*types. - Updated frontend UI tests to assert protocol-only Console behavior and absence of operation HTTP paths.
Verification:
nix develop -c cargo fmt -- --checknix develop -c cargo check -p worker-runtime -p yoi-workspace-server -p client -p tuinix develop -c cargo test -p client backend_runtime --libnix develop -c cargo test -p worker-runtime --features ws-server --lib protocol_wsnix develop -c cargo test -p yoi-workspace-server protocol_ws --libnix develop -c cargo test -p yoi-workspace-server proxy_maps_runtime_worker_not_found_http_404_to_protocol_error_event --libdeno test --allow-read web/workspace/src/lib/workspace/console/worker-console.ui.test.tsfromweb/workspacegit diff --check
Implementation report
Bug fix after manual TUI send failure:
Observed symptom:
- TUI send over Backend protocol reported a
does not support Worker protocol command transportstyle error.
Root cause:
/events/wshad been removed and/protocol/wsunified, but workspace-server still handled inbound clientprotocol::Methodby callingRuntimeRegistry::send_protocol_method(...).- For remote runtime-backed workers, Backend must be only a protocol WS proxy. Calling the registry default method hits the unsupported path instead of tunneling the frame to the runtime's
/protocol/ws.
Fix:
- Workspace-server now branches by observation/protocol source:
RemoteWs: proxy raw WebSocket frames bidirectionally between client/api/.../protocol/wsand runtime/v1/.../protocol/ws. Backend does not deserialize or interpret method frames in this path.Embedded: use in-process runtime adapter for method dispatch while streaming embedded observation events.
- Added/updated test so sending
Method::ListCompletionsthrough the workspace-server protocol proxy returnsEvent::Completionsfrom the runtime, proving method frames reach the runtime instead of the Backend unsupported fallback.
Verification:
nix develop -c cargo fmt -- --checknix develop -c cargo check -p yoi-workspace-server -p client -p worker-runtimenix develop -c cargo test -p yoi-workspace-server proxies_worker_protocol_ws_as_raw_events --libnix develop -c cargo test -p client backend_runtime --libnix develop -c cargo test -p worker-runtime --features ws-server --lib protocol_wsnix develop -c cargo test -p yoi-workspace-server protocol_ws --libdeno test --allow-read web/workspace/src/lib/workspace/console/worker-console.ui.test.tsgit diff --check
Implementation report
Bug fix for missing local echo in TUI/Web:
Observed symptom:
- Sending from TUI/Web over unified
/protocol/wsreached the runtime and was accepted asprotocol_method, but the user's sent content did not appear in the Console.
Root cause:
- The old HTTP input path emitted observation events for accepted input via
input_protocol_event(...)(Event::UserMessagefor user input /Event::SystemItemfor system input). - The new raw
Method::Run/Method::Notifyprotocol path dispatched the method to the execution backend but did not record the corresponding observation echo event. - Therefore the unified protocol stream had assistant/runtime events, but no echo event representing the user-sent content.
Fix:
- Added protocol-method observation echo in
worker-runtimeafter acceptedRuntime::send_protocol_method(...)dispatch. Method::Runnow recordsEvent::UserMessage { segments }.Method::Notifynow records a system inputEvent::SystemItem.- Kept compact/list_rewind_targets/register_peer command echoes aligned with the old command-input observation shape.
- Added a runtime protocol WS regression test: send
Method::Runover/protocol/wsand assert the same socket receivesEvent::UserMessagewith the sent text.
Verification:
nix develop -c cargo fmt -- --checknix develop -c cargo check -p worker-runtime -p yoi-workspace-server -p client -p tuinix develop -c cargo test -p worker-runtime --features ws-server --lib protocol_ws_echoes_accepted_run_as_user_messagenix develop -c cargo test -p worker-runtime --features ws-server --lib protocol_wsnix develop -c cargo test -p yoi-workspace-server protocol_ws --libnix develop -c cargo test -p client backend_runtime --libgit diff --check