close: eliminate test-only env vars

work-items/closed/20260531-085959-eliminate-test-only-env-vars/item.md

@@ -2,12 +2,12 @@
 id: 20260531-085959-eliminate-test-only-env-vars
 slug: eliminate-test-only-env-vars
 title: Tests: eliminate test-only environment variables
-status: open
+status: closed
 kind: task
 priority: P2
 labels: [test, env, cleanup]
 created_at: 2026-05-31T08:59:59Z
-updated_at: 2026-05-31T10:03:55Z
+updated_at: 2026-05-31T10:04:28Z
 assignee: null
 legacy_ticket: null
 ---

work-items/closed/20260531-085959-eliminate-test-only-env-vars/resolution.md

@@ -0,0 +1,18 @@
+Removed test-only environment-variable usage from active code.
+
+Implementation:
+- Removed `INSOMNIA_TEST_*` Brave WebSearch test key generation/dependency.
+- Split Brave search request execution so tests can inject an API key directly into a private helper.
+- Preserved production behavior: WebSearch still reads configured `web.search.api_key_env` and fails closed for missing/empty values.
+- Updated `docs/environment.md` so test-only env vars are not listed as supported surface.
+
+Review:
+- External reviewer `eliminate-test-env-vars-reviewer-20260531` approved implementation commit `e64a5595956c970b090cdce851cc962e92723a97`.
+
+Validation after merge:
+- `cargo fmt --check`
+- `cargo test -p tools`
+- `cargo check -p tools` (passed with unrelated existing `llm-worker` dead_code warning)
+- `./tickets.sh doctor`
+- `git diff --check`
+- `git grep -n "INSOMNIA_TEST" -- ':!work-items' || true` produced no active references.

work-items/closed/20260531-085959-eliminate-test-only-env-vars/thread.md

@@ -35,4 +35,30 @@ Validation adequacy:
 - Reviewer performed read-only diff/source/docs/grep review and did not rerun tests.
 
 
+---
+
+<!-- event: close author: hare at: 2026-05-31T10:04:28Z status: closed -->
+
+## Closed
+
+Removed test-only environment-variable usage from active code.
+
+Implementation:
+- Removed `INSOMNIA_TEST_*` Brave WebSearch test key generation/dependency.
+- Split Brave search request execution so tests can inject an API key directly into a private helper.
+- Preserved production behavior: WebSearch still reads configured `web.search.api_key_env` and fails closed for missing/empty values.
+- Updated `docs/environment.md` so test-only env vars are not listed as supported surface.
+
+Review:
+- External reviewer `eliminate-test-env-vars-reviewer-20260531` approved implementation commit `e64a5595956c970b090cdce851cc962e92723a97`.
+
+Validation after merge:
+- `cargo fmt --check`
+- `cargo test -p tools`
+- `cargo check -p tools` (passed with unrelated existing `llm-worker` dead_code warning)
+- `./tickets.sh doctor`
+- `git diff --check`
+- `git grep -n "INSOMNIA_TEST" -- ':!work-items' || true` produced no active references.
+
+
 ---