Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity
9e0f8e9aad
yoi/.yoi/tickets/00001KX6WVNPD/thread.md

16 KiB
Raw Blame History

作成

LocalTicketBackend によって作成されました。

Plan

整理結果:

  1. 00001KX6Y2A9Q WorkerFilesystemAuthority

    • hard dependency なし。
    • no-workdir を filesystem authority none として型で表現する基盤。

  2. 00001KX6WVNPD Embedded no-workdir Worker authority policy

    • depends_on: 00001KX6Y2A9Q。
    • UI/API の workdir 任意化と embedded no-workdir tool surface 制御を実装する。

  3. 00001KX6Y6ZEA WorkspaceBackend / workspace_id 分離

    • depends_on: 00001KX6Y2A9Q。
    • workspace_root path 依存を workspace_id + Runtime-injected WorkspaceClient へ移行する。
    • embedded no-workdir MVP をブロックしない。

Hard dependencies は WorkerFilesystemAuthority を共通前提に限定する。WorkspaceBackend 分離は embedded no-workdir policy の MVP には related だが depends_on にはしない。

Decision

前提チケット 00001KX6Y2A9Q で Worker 直下の作業ディレクトリ property は削除されるため、このチケットはその存在を前提にしない。embedded workdir ありは WorkerFilesystemAuthority::Local、workdir なしは WorkerFilesystemAuthority::None として扱い、tool registration もその authority から導出する。

Intake summary

Marked ready by yoi ticket state.

State changed

Marked ready by yoi ticket state.

State changed

Ticket を workspace-panel が queued にしました。

Decision

Routing decision: blocked_by_dependency

Reason:

  • Dashboard queue authorization was inspected, but this Ticket has an explicit typed depends_on relation to 00001KX6Y2A9Q。
  • 00001KX6Y2A9Q is currently inprogress and is implementing the Worker filesystem-authority / no-workdir / cwd-removal boundary this Ticket depends on。
  • Starting this Ticket before that boundary is reviewed/merged would duplicate or conflict with constructor/restore/spawn/tool-registration changes。
  • Therefore this routing pass leaves the Ticket queued and does not record queued -> inprogress, create a worktree, or spawn role Pods。

Evidence checked:

  • Ticket body / recent thread / artifacts。
  • TicketRelationQuery(00001KX6WVNPD): includes dependency on 00001KX6Y2A9Q。
  • TicketList(inprogress): 00001KX6Y2A9Q is the active inprogress Ticket。
  • Orchestrator worktree status: clean。

Next action:

  • Re-route this Ticket after 00001KX6Y2A9Q is approved, merged, validated, and closed。
  • Escalate only if a human explicitly requests combined implementation in the same branch/worktree。

Decision

Routing decision: implementation_ready

Reason:

  • 前提 Ticket 00001KX6Y2A9Q は approved / merged / final-validated / closed 済みで、WorkerFilesystemAuthority::{None, Local} と no-workdir core filesystem/Bash tool omission boundary が利用可能になった。
  • この Ticket は embedded Runtime の workdir 未指定 Worker 作成 policy と UI/API 制約に集中しており、目的・binding decision・受け入れ条件が具体的である。
  • TicketRelationQuery(00001KX6WVNPD) の blocker view は空で、残る outgoing depends_on 00001KX6Y2A9Q は closed prerequisite になっている。
  • TicketOrchestrationPlanQuery(00001KX6WVNPD) の既存 waiting note は prerequisite inprogress を理由にしたものだったため、現在は解消済み。
  • Orchestrator worktree は clean。既存 child implementation branch/worktree は見当たらない。

Evidence checked:

  • Ticket body / thread / relations / orchestration plan。
  • Related closed Ticket 00001KX6Y2A9Q resolution/review/validation evidence。
  • TicketList(inprogress): 0 件。
  • git status --short --branch and git worktree list in /home/hare/Projects/yoi/.worktree/orchestration。
  • Current queue also contains related 00001KX6Y6ZEA, but its Worker workspace-backend refactor touches overlapping Worker context/constructor surfaces; it will be held separately with a conflict/migration-boundary reason rather than started in parallel。

IntentPacket:

Intent:

  • Embedded Runtime 選択時に、workdir 未指定の guidance/conversation-oriented Worker を作成できるようにする。
  • Embedded no-workdir Worker は WorkerFilesystemAuthority::None として作られ、repository filesystem authority / cwd fallback / filesystem tools / Bash を持たない。

Binding decisions / invariants:

  • no-workdir authority は merged WorkerFilesystemAuthority::None を使う。
  • workspace root / process cwd / runtime cwd / manifest override / default scope を filesystem authority fallback にしない。
  • filesystem tools (Read, Write, Edit, Glob, Grep) と Bash は no-workdir embedded Worker では construct/register/model-visible にしない。
  • Bash は filesystem sandbox ではないため、no-workdir embedded では登録しない。
  • non-embedded または local/filesystem-authority-required launch path では、既存の workdir 必須制約または明示 authority requirement を維持する。
  • Worker 直下の cwd property / worker.cwd() 前提に戻さない。

Requirements / acceptance criteria:

  • UI/API 経由で embedded Runtime の workdir 未指定 Worker create ができる。
  • embedded + workdir ありは materialized binding を WorkerFilesystemAuthority::Local と Worker summary/detail に反映する。
  • embedded + workdir なしは WorkerFilesystemAuthority::None になり、model-visible tool surface に fs tools / Bash が出ないことをテストで確認できる。
  • Glob / Grep path 省略や Bash initial directory が no-workdir embedded の権限漏れにならない。
  • Browser/UI では workdir optional が embedded Runtime に限られ、non-embedded/local authority path の制約を緩めない。

Implementation latitude:

  • API DTO / UI form model / runtime spawn request shape の具体的な整理は coder が既存 pattern に沿って選んでよい。
  • workdir 未指定状態の UI 表示文言・validation placement は、binding invariant を満たす範囲で local tactic としてよい。
  • tests の配置は worker-runtime / workspace-server / web の既存近接 test pattern に合わせてよい。

Escalate if:

  • embedded no-workdir Worker に workspace API access を付けるために WorkspaceBackend / WorkspaceClient の先行導入が必須になる場合。
  • no-workdir Worker へ fs/Bash tool の error-only stub や empty-scope fallback を登録したくなる場合。
  • non-embedded Worker の workdir requirement を緩める必要が出る場合。
  • WorkerFilesystemAuthority の既存 invariant を変更する必要が出る場合。

Validation:

  • git diff --check
  • focused grep/check that no no-workdir path reintroduces worker.cwd() or local cwd fallback。
  • cargo test -p worker --lib --tests if worker crate is touched。
  • cargo test -p worker-runtime --features ws-server,fs-store
  • cargo test -p yoi-workspace-server --lib
  • cargo check -p yoi
  • cd web/workspace && deno task check && deno task test if web/API/types are touched。
  • yoi ticket doctor
  • nix build .#yoi --no-link

Current code map / likely touch points:

  • crates/worker/src/worker.rs, crates/worker/src/controller.rs for existing authority boundary verification only if needed。
  • crates/worker-runtime/src/worker_backend.rs / working-directory binding and embedded spawn paths。
  • crates/workspace-server/src/server.rs / API DTOs for Worker create/runtime options。
  • web/workspace worker creation UI/types if workdir optionality is exposed there。

Critical risks / reviewer focus:

  • Hidden filesystem authority through workspace root / process cwd / runtime cwd fallback。
  • no-workdir Worker showing fs tools/Bash in model-visible schema。
  • empty-scope/error-only fs tool registration rather than no registration。
  • UI/API accidentally allowing non-embedded no-workdir Worker where local filesystem authority is still required。
  • regression of embedded workdir-present Worker status/tool cwd behavior。

State changed

Prerequisite 00001KX6Y2A9Q is now closed and merged. This Ticket is accepted for implementation before creating a worktree or spawning role Pods.

Implementation report

Implementation progress report:

  • Coder Pod yoi-coder-00001KX6WVNPD-no-workdir-policy completed an implementation pass in /home/hare/Projects/yoi/.worktree/00001KX6WVNPD-embedded-no-workdir-policy on branch work/00001KX6WVNPD-embedded-no-workdir-policy。
  • Implementation commit: 10267869ae0dfe02e186dc69fec14151926f5009 feat: enforce embedded no-workdir worker policy。
  • Files touched:
    • crates/workspace-server/src/server.rs
    • web/workspace/src/lib/workspace-sidebar/types.ts
    • web/workspace/src/lib/workspace-sidebar/worker-launch.test.ts
    • web/workspace/src/routes/w/[workspaceId]/workers/new/+page.svelte
  • Orchestrator inspected worktree status, branch log, commit stats, git diff --check 83c9d884..HEAD, and rg 'worker\\.cwd\\(\\)' .; worktree was clean, diff check passed, and no worker.cwd() matches were found。

Implementation summary:

  • Added Browser/API launch metadata for whether a runtime requires working directory selection。
  • Embedded Runtime can be marked as workdir-optional; non-embedded Runtime remains workdir-required。
  • Server-side creation path rejects no-workdir Worker creation unless the target runtime is embedded, using a typed diagnostic。
  • Browser Worker creation UI offers “no workdir / embedded conversation only” only when the selected runtime allows it。
  • Relative cwd input is hidden for no-workdir launch and UI text explains no filesystem tools or Bash are available without workdir。
  • Tests were added/updated for launch metadata, non-embedded no-workdir rejection, and web request construction for embedded no-workdir launch。

Next action:

  • Route to external Reviewer Pod before merge/close decisions。

Review: approve

External review result: approve

Evidence:

  • UI/API optionality is correctly bounded: launch options expose working_directory_required and set it false only for embedded runtime (crates/workspace-server/src/server.rs:749, :3823), while browser request construction omits working_directory for embedded no-workdir mode and tests cover that (web/workspace/src/lib/workspace-sidebar/worker-launch.test.ts:80)。
  • Non-embedded no-workdir is rejected in workspace/API launch paths (server.rs:2639, :2839) with tests covering the 400 behavior (server.rs:6383, :6554)。
  • Authority boundary is preserved: absent materialized workdir reaches runtime as no working directory (server.rs:2652) and worker-runtime maps that to WorkerFilesystemAuthority::None; workdir-present maps to Local(root, cwd) (crates/worker-runtime/src/worker_backend.rs:301)。
  • Tool surface/no fallback is covered by existing runtime tests asserting no cwd observation and omission of Read/Write/Edit/Glob/Grep/Bash for no-workdir workers (worker_backend.rs:1151, :1216)。
  • Workdir-present behavior remains covered by materialized binding assertions (worker_backend.rs:1151) and server worker creation still links/summarizes workdir-present workers。
  • Browser labeling is explicit: embedded mode offers “No working directory — guidance-only Worker; filesystem tools are disabled” and non-embedded paths require selection (+page.svelte:153, :289)。

Validation performed by reviewer:

  • cargo test -p yoi-workspace-server no_workdir -- --nocapture
  • cargo test -p worker-runtime --features ws-server --lib -- --nocapture
  • cd web/workspace && deno task test
  • Final git status --short was clean。

Blockers: none。 Non-blocking notes: none。

Implementation report

Merge / final validation report:

  • Reviewer approved the implementation with no blockers。
  • Merged branch work/00001KX6WVNPD-embedded-no-workdir-policy into orchestration branch with merge commit 2f7b8094 merge: embedded no-workdir worker policy。
  • Final validation was rerun in /home/hare/Projects/yoi/.worktree/orchestration after merge。

Validation passed:

  • rg 'worker\\.cwd\\(' . || true: no matches。
  • git diff --check
  • cargo test -p worker-runtime --features ws-server,fs-store
  • cargo test -p yoi-workspace-server --lib
  • cargo check -p yoi
  • cd web/workspace && deno task check
  • cd web/workspace && deno task test
  • yoi ticket doctor
  • nix build .#yoi --no-link

Validation log:

  • /run/user/1000/yoi/yoi-orchestrator/bash-output/embedded-no-workdir-final-validation-1783728763.txt

Reviewed/merged implementation commit:

  • 10267869 feat: enforce embedded no-workdir worker policy

State changed

Implementation was reviewed, merged into orchestration branch, and final validation passed. Moving to done before closure.

State changed

Ticket を closed にしました。

完了

Embedded no-workdir Worker authority policy を実装・レビュー・merge・検証した。

実装内容:

  • Runtime launch metadata に working_directory_required を追加し、embedded Runtime のみ workdir optional として扱うようにした。
  • Workspace/API Worker create path で、embedded Runtime では no-workdir Worker creation を許可し、non-embedded Runtime では no-workdir creation を typed diagnostic で拒否するようにした。
  • Embedded no-workdir launch は Runtime へ working directory なしで渡され、merged WorkerFilesystemAuthority 境界により WorkerFilesystemAuthority::None になる。
  • Workdir-present embedded Worker は materialized binding を WorkerFilesystemAuthority::Local として保持する既存 behavior を維持。
  • Browser Worker creation UI で embedded Runtime の場合だけ “No working directory — guidance-only Worker; filesystem tools are disabled” を選べるようにした。
  • No-workdir launch では relative cwd input を隠し、filesystem tools / Bash が disabled であることを明示。
  • Tests で launch metadata、non-embedded no-workdir rejection、embedded no-workdir request construction、および existing runtime tests による no-workdir tool omission/no cwd fallback を確認。

Review:

  • Reviewer approved with no blockers。
  • Evidence included API optionality bounds, non-embedded rejection, authority construction path, no filesystem/Bash tool surface coverage, workdir-present behavior, and Browser labeling。

Merge / validation:

  • Merge commit: 2f7b8094 merge: embedded no-workdir worker policy。
  • Final validation passed:
    • rg 'worker\\.cwd\\(' . || true
    • git diff --check
    • cargo test -p worker-runtime --features ws-server,fs-store
    • cargo test -p yoi-workspace-server --lib
    • cargo check -p yoi
    • cd web/workspace && deno task check
    • cd web/workspace && deno task test
    • yoi ticket doctor
    • nix build .#yoi --no-link
  • Validation log: /run/user/1000/yoi/yoi-orchestrator/bash-output/embedded-no-workdir-final-validation-1783728763.txt