Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity
e8d8f139d0
yoi/work-items/open/20260531-085959-remove-insomnia-pod-command-env/thread.md

1.7 KiB
Raw Blame History

Created

Created by tickets.sh create.

Review: approve

External reviewer: remove-insomnia-pod-command-reviewer-20260531 Reviewed implementation commit: c618fa6 (cli: remove pod command env override) Verdict: approve

Summary:

  • INSOMNIA_POD_COMMAND is removed as an active runtime/config/test override.
  • Pod runtime launch remains typed through PodRuntimeCommand, defaulting to current executable plus the pod prefix argument.
  • SpawnPod tests now use typed injection rather than process-wide env mutation.
  • Production spawn/restore paths still use PodRuntimeCommand::resolve(), preserve detached process handling, and retain the ready/socket delivery behavior.

Requirements mapping:

  • No active non-work-item INSOMNIA_POD_COMMAND references remain in the implementation branch.
  • No replacement env var was introduced.
  • No insomnia-pod binary/alias, Pod protocol/flag/profile semantic changes, or tui rename were introduced.

Blockers: none.

Non-blocking follow-up:

  • Merge conflict in docs/environment.md is expected after eliminate-test-only-env-vars; integration should keep the newer generic test-only wording while preserving removal of explicit INSOMNIA_POD_COMMAND references.

Validation adequacy:

  • Coder validation covered fmt, helper/client/pod tests, cargo check, doctor, diff check, and active-reference grep.
  • Reviewer additionally reran targeted tests/checks in the implementation worktree and confirmed no active refs for INSOMNIA_POD_COMMAND, POD_COMMAND_OVERRIDE_ENV, from_override_env, or executable_only outside work items.