Hare/yoi
1
1
Fork 0
Code Actions Packages Releases Activity

review: approve pod command env removal

Browse Source
This commit is contained in:
Keisuke Hirata 2026-05-31 19:09:52 +09:00
parent e8e50bfa6b
commit e8d8f139d0
No known key found for this signature in database
2 changed files with 32 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
work-items/open/20260531-085959-remove-insomnia-pod-command-env/item.md
View File

@ -7,7 +7,7 @@ kind: task
priority: P2
labels: [cli, pod, env]
created_at: 2026-05-31T08:59:59Z
updated_at: 2026-05-31T08:59:59Z
updated_at: 2026-05-31T10:09:52Z
assignee: null
legacy_ticket: null
---

31
work-items/open/20260531-085959-remove-insomnia-pod-command-env/thread.md
View File

@ -4,4 +4,35 @@
Created by tickets.sh create.
---
<!-- event: review author: hare at: 2026-05-31T10:09:52Z status: approve -->
## Review: approve
External reviewer: `remove-insomnia-pod-command-reviewer-20260531`
Reviewed implementation commit: `c618fa6` (`cli: remove pod command env override`)
Verdict: approve
Summary:
- `INSOMNIA_POD_COMMAND` is removed as an active runtime/config/test override.
- Pod runtime launch remains typed through `PodRuntimeCommand`, defaulting to current executable plus the `pod` prefix argument.
- SpawnPod tests now use typed injection rather than process-wide env mutation.
- Production spawn/restore paths still use `PodRuntimeCommand::resolve()`, preserve detached process handling, and retain the ready/socket delivery behavior.
Requirements mapping:
- No active non-work-item `INSOMNIA_POD_COMMAND` references remain in the implementation branch.
- No replacement env var was introduced.
- No `insomnia-pod` binary/alias, Pod protocol/flag/profile semantic changes, or `tui` rename were introduced.
Blockers: none.
Non-blocking follow-up:
- Merge conflict in `docs/environment.md` is expected after `eliminate-test-only-env-vars`; integration should keep the newer generic test-only wording while preserving removal of explicit `INSOMNIA_POD_COMMAND` references.
Validation adequacy:
- Coder validation covered fmt, helper/client/pod tests, cargo check, doctor, diff check, and active-reference grep.
- Reviewer additionally reran targeted tests/checks in the implementation worktree and confirmed no active refs for `INSOMNIA_POD_COMMAND`, `POD_COMMAND_OVERRIDE_ENV`, `from_override_env`, or `executable_only` outside work items.
---